Github user i closed the pull request at:
https://github.com/apache/thrift/pull/517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/517#issuecomment-111595926
I agree with @prashantv and just committed the other patch. If you do not
share our opinion please feel free to rebase and improve the patch, otherwise
you can probably
Github user prashantv commented on the pull request:
https://github.com/apache/thrift/pull/517#issuecomment-111205380
@i Just started a PR for the same issue, didn't see your fix.
I think it's better to not set p.Response, since it affects other code
(IsOpen returns true, Read
GitHub user i opened a pull request:
https://github.com/apache/thrift/pull/517
Always set response on THttpClient
Due to an early return, not setting response leads to a file descriptor
leak. This fixes that by letting the client close its transport every time.
You can merge this
