Github user ruijiang commented on the pull request:
https://github.com/apache/thrift/pull/161#issuecomment-49975154
Thanks for the review. This turns out to be harder than I thought. The main
issue is dealing with two states:
--Whether the bit is set.
--Whether the member
Github user ruijiang closed the pull request at:
https://github.com/apache/thrift/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/161#issuecomment-49801301
I have issues with the test suite ran by *make check*, could you take care
on this?
/lib/java/gen-javabean/thrift/test/OneOfEachBeans.java:440: error: cann
GitHub user ruijiang opened a pull request:
https://github.com/apache/thrift/pull/161
Always use bit field or BitSet for isSetXXX
This is to address the issue:
https://issues.apache.org/jira/browse/THRIFT-1827
Due to the the inconsistent behavior of isSet for primitive field and
