[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-09-19 Thread captncraig
Github user captncraig commented on the pull request: https://github.com/apache/thrift/pull/177#issuecomment-56225456 Yeah, I agree that scenario sucks. The problem is, I am not sure that all of the transports have a way to really do peek. TcpSocket for example only has a Read operati

[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-09-19 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/177#issuecomment-56222777 I like the idea. But Peek() isn't actually a peek, it is a read operation. Let's just take this (theoretical) scenario: * call `transport.Peek()` to effectivel

[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-08-08 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/177#issuecomment-51640422 tracked in THRIFT-2654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-08-08 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/177 C# - reduce number of server exceptions The current server implementation reads in a loop until the client closes, at which point an exception is thrown by the processor/transport and caught by