[GitHub] thrift pull request: DART: Allow decode JSON escaped unicode strin...

2015-10-20 Thread phongphan
Github user phongphan commented on the pull request: https://github.com/apache/thrift/pull/658#issuecomment-149763148 Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] thrift pull request: DART: Allow decode JSON escaped unicode strin...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: DART: Allow decode JSON escaped unicode strin...

2015-10-20 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/658#discussion_r42543775 --- Diff: lib/dart/lib/src/protocol/t_json_protocol.dart --- @@ -321,12 +327,36 @@ class TJsonProtocol extends TProtocol { continue; }

[GitHub] thrift pull request: DART: Allow decode JSON escaped unicode strin...

2015-10-20 Thread phongphan
Github user phongphan commented on the pull request: https://github.com/apache/thrift/pull/658#issuecomment-149635862 Hi @nsuke, Thanks, created at [THRIFT-3396](https://issues.apache.org/jira/browse/THRIFT-3396). --- If your project is set up for it, you can reply to this email

[GitHub] thrift pull request: DART: Allow decode JSON escaped unicode strin...

2015-10-20 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/658#issuecomment-149628493 Hello @phongphan , thanks for the patch, would you mind creating a JIRA ticket for this ? http://thrift.apache.org/docs/HowToContribute --- If your project is set up

[GitHub] thrift pull request: DART: Allow decode JSON escaped unicode strin...

2015-10-20 Thread phongphan
GitHub user phongphan opened a pull request: https://github.com/apache/thrift/pull/658 DART: Allow decode JSON escaped unicode string. Hi This patch allow Dart's json protocol to be able to comsume escaped unicode string (\u). To make the `readString` test runnable, I h