[GitHub] thrift pull request: Fix hang in go tests.

2016-02-03 Thread jsirois
Github user jsirois commented on the pull request: https://github.com/apache/thrift/pull/833#issuecomment-179546030 Tested with `make check`, which no-longer hangs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: Fix hang in go tests.

2016-02-03 Thread jsirois
Github user jsirois commented on the pull request: https://github.com/apache/thrift/pull/833#issuecomment-179546686 @dimiro1 - if you have a chance to review, I'd be grateful. This is re #785 and a test hang under `make check` that I bisected to it. --- If your project is set up

[GitHub] thrift pull request: Fix hang in go tests.

2016-02-03 Thread jsirois
GitHub user jsirois opened a pull request: https://github.com/apache/thrift/pull/833 Fix hang in go tests. Previously tests would hang in a forground call to `server.Serve()`. Kill this call since `server.Listen(); go server.AcceptLoop()` is already performed and is the