Github user andrewcox commented on the pull request:
https://github.com/apache/thrift/pull/731#issuecomment-162639103
Updated the commit name to have the correct prefix (the current commit is
otherwise unchanged)
Yes, I was just checking whether this looks like what you want,
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/731#issuecomment-162651073
Yes, CI will re-run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/731#issuecomment-162352720
Great patch Andrew!
I would really like to get FLOAT up and running here. The blocker for not
merging now is breaking other languages with this at the moment,
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/731#issuecomment-162083194
Thanks Andrew! I will review this during the weekend...
Could you please add THRIFT-2457 as prefix within your commits as mentioned
within
GitHub user andrewcox opened a pull request:
https://github.com/apache/thrift/pull/731
Support for float type (part 1: cpp)
Ported from fbthrift
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewcox/thrift port-float-type
