[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-21 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/307#issuecomment-67772599 Obsoleted by this https://github.com/apache/thrift/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-19 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/307#issuecomment-67672885 The build has been fixed (Travis failure is gcc internal error + make cross instability). I also added CMake build. --- If your project is set up for it, you can

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/307#discussion_r21424261 --- Diff: configure.ac --- @@ -152,11 +152,26 @@ if test $with_cpp = yes; then AC_PATH_PROGS([QT_MOC], [moc-qt4 moc]) have_qt=$success

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/307#discussion_r21424274 --- Diff: lib/cpp/Makefile.am --- @@ -22,6 +22,9 @@ AUTOMAKE_OPTIONS = subdir-objects moc_%.cpp: %.h $(QT_MOC) $(QT_CFLAGS) $ -o $@

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/307#issuecomment-65941695 Yes, sorry for prematurely pushing the fix. I'm having difficulty with Ubuntu 12.04 + trusty apt repo with Qt5 (on travis). It is specifically caused by moc