Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/648
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user phongphan commented on a diff in the pull request:
https://github.com/apache/thrift/pull/648#discussion_r42150026
--- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp ---
@@ -736,7 +741,23 @@ uint32_t TJSONProtocol::readJSONString(std::string&
str, bool skipContext)
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/648#discussion_r42143016
--- Diff: lib/cpp/test/JSONProtoTest.cpp ---
@@ -269,3 +271,70 @@ BOOST_AUTO_TEST_CASE(test_json_proto_8) {
BOOST_CHECK_THROW(ooe2.read(proto.get()),
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/648#discussion_r42142463
--- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp ---
@@ -736,7 +741,23 @@ uint32_t TJSONProtocol::readJSONString(std::string&
str, bool skipContext) {
Github user phongphan commented on the pull request:
https://github.com/apache/thrift/pull/648#issuecomment-147209336
Looks like `clang++` crashed makes one job failed.
> make TestServer TestClient StressTest StressTestNonBlocking
> make[4]: Entering directory `/home/travis/bui
GitHub user phongphan reopened a pull request:
https://github.com/apache/thrift/pull/648
THRIFT-2411 C++: UTF-8 sent by PHP as JSON is not understood by
TJsonProtocol, redux
Hi
This patch allow consuming JSON encoded by older version of PHP (< 5.4)
which the `json_encode` funct
Github user phongphan closed the pull request at:
https://github.com/apache/thrift/pull/648
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
GitHub user phongphan opened a pull request:
https://github.com/apache/thrift/pull/648
THRIFT-2411 C++: UTF-8 sent by PHP as JSON is not understood by
TJsonProtocol, redux
Hi
This patch allow consuming JSON encoded by older version of PHP (< 5.4)
which the `json_encode` functio
Github user phongphan closed the pull request at:
https://github.com/apache/thrift/pull/647
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user phongphan commented on the pull request:
https://github.com/apache/thrift/pull/647#issuecomment-147109386
The branch is quite messy right now and not ready to merge.
I will clean it up and create the new PR.
Sorry the the noise.
---
If your project is set up f
Github user phongphan commented on the pull request:
https://github.com/apache/thrift/pull/647#issuecomment-147052566
Looks like clang in travis-ci doesn't use libc++.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user phongphan opened a pull request:
https://github.com/apache/thrift/pull/647
THRIFT-2411 C++: UTF-8 sent by PHP as JSON is not understood by
TJsonProtocol
Hi
This patch allow consuming JSON encoded by older version of PHP (< 5.4)
which doesn't support JSON_UNESCA
12 matches
Mail list logo
