[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

2015-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

2015-11-03 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/357#issuecomment-153356845 There were several build issues. I'll commit the fixed version shortly after #677. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

2015-11-03 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/357#issuecomment-153325696 @nsuke Yes, please do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

2015-11-02 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/357#issuecomment-153061344 What happened to this ? Although it does not cleanly apply at all anymore, with "git merge" it is still straightforward to merge. If there isn't any concern, I'll m