[GitHub] thrift pull request: THRIFT-2939: Js on par with nodejs

2015-01-28 Thread malandrew
Github user malandrew commented on the pull request: https://github.com/apache/thrift/pull/353#issuecomment-71891630 Good to see these changes. I encountered some of the same issues. I hacked around for a few days and ported all the browser features to the nodejs codebase for use with

[GitHub] thrift pull request: THRIFT-2939: Js on par with nodejs

2015-01-11 Thread radekg
GitHub user radekg opened a pull request: https://github.com/apache/thrift/pull/353 THRIFT-2939: Js on par with nodejs The generated code for regular JS differs from NodeJS code. NodeJS uses direct return values from `read()` while regular JS code expects a value from `read()` to b