GitHub user kostya-sh opened a pull request:

    https://github.com/apache/thrift/pull/506

    THRIFT-3169 go: do not export thrift.TestEnum and thrift.TestStruct

    Rename serializer_types.go to serializer_types_test.go so it is only used by
    'go test'.
    
    Rename TestEnum to MyTestEnum and TestStruct to MyTestStruct as methods like
    TestEnumFromString confuse 'go test' (all TestXXX methods are test methods).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kostya-sh/thrift THRIFT-3169

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #506
    
----
commit 38273796487ff4e7f12781f05ed3f3e345511d4f
Author: Konstantin Shaposhnikov <k.shaposhni...@gmail.com>
Date:   2015-05-20T14:49:34Z

    THRIFT-3169 go: do not export thrift.TestEnum and thrift.TestStruct
    
    Rename serializer_types.go to serializer_types_test.go so it is only used by
    'go test'.
    
    Rename TestEnum to MyTestEnum and TestStruct to MyTestStruct as methods like
    TestEnumFromString confuse 'go test' (all TestXXX methods are test methods).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to