Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/698#issuecomment-156777456
It seems that IE10 has btoa/atob and it was the first version.
http://caniuse.com/#feat=atob-btoa
https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/btoa
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/698
THRIFT-3200 JS and nodejs do not encode JSON protocol binary fields aâ¦
â¦s base64
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift
Github user beberg commented on the pull request:
https://github.com/apache/thrift/pull/698#issuecomment-156734167
Agree it should be commited, but leave behind a ticket for universal
support.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/698#issuecomment-156718579
:+1: great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/698#issuecomment-156721497
I think it is ok to not support IE < v10
This change needs to be committed base64 can be another step.
test integration done here is awesome!
---
If your
Github user beberg commented on the pull request:
https://github.com/apache/thrift/pull/698#issuecomment-156719878
Sorry, to clarify btoa() was only added to IE in v10, so this isn't a fully
portable implementation.
---
If your project is set up for it, you can reply to this email
