[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-27 Thread afds
Github user afds commented on the pull request: https://github.com/apache/thrift/pull/627#issuecomment-143589859 I'm perfectly fine to make it default. Theoretically possible issues is that someone heavily relies on HashMap/HashSet or uses _null_ keys/elements (EnumMap/EnumSet

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-27 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/627#discussion_r40506016 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -5139,8 +5215,11 @@ THRIFT_REGISTER_GENERATOR( "reuse-objects: Data objects will n

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-26 Thread afds
Github user afds commented on the pull request: https://github.com/apache/thrift/pull/627#issuecomment-143475735 https://issues.apache.org/jira/browse/THRIFT-3357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-26 Thread afds
GitHub user afds opened a pull request: https://github.com/apache/thrift/pull/627 THRIFT-3357: enum_containers option to generate EnumSet/EnumMap Additional java compiler option to generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are enums. You can merge t