[GitHub] thrift pull request: THRIFT-3405

2015-11-19 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/701#issuecomment-158191235 Committed per 13ac77daf031443ebdfbee02bad528f53b6212eb, this can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] thrift pull request: THRIFT-3405

2015-11-17 Thread justonia
GitHub user justonia opened a pull request: https://github.com/apache/thrift/pull/701 THRIFT-3405 Implementation for THttpClient as referenced by: https://issues.apache.org/jira/browse/THRIFT-3405 Some lines within the RemainingBytes() method were changed as a

[GitHub] thrift pull request: THRIFT-3405

2015-11-17 Thread justonia
Github user justonia commented on the pull request: https://github.com/apache/thrift/pull/701#issuecomment-157462815 I also forgot to mention that all changes are additive and do not change the existing public API. --- If your project is set up for it, you can reply to this email

[GitHub] thrift pull request: THRIFT-3405

2015-11-17 Thread justonia
Github user justonia commented on the pull request: https://github.com/apache/thrift/pull/701#issuecomment-157474702 The CI failure does not seem related to my changes... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.