[GitHub] thrift pull request: THRIFT-3520 Dart TSocket onError type as Obje...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3520 Dart TSocket onError type as Obje...

2016-01-06 Thread stevenosborne-wf
Github user stevenosborne-wf commented on the pull request: https://github.com/apache/thrift/pull/770#issuecomment-169392638 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3520 Dart TSocket onError type as Obje...

2016-01-04 Thread markerickson-wf
GitHub user markerickson-wf opened a pull request: https://github.com/apache/thrift/pull/770 THRIFT-3520 Dart TSocket onError type as Object Dart TSocket exposes `onError` as a `Stream`. However, the payload may be either a String or an Error, and should be typed as `Stream`.

[GitHub] thrift pull request: THRIFT-3520 Dart TSocket onError type as Obje...

2016-01-04 Thread evanweible-wf
Github user evanweible-wf commented on the pull request: https://github.com/apache/thrift/pull/770#issuecomment-168816225 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature