Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-170418643
@hcorg oh I actually got your point, thanks for catching this. Comments are
harder to read than C++ :p
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169677418
Sure, that's the whole point of putting this as a PR.
In a nutshell I believe it does not change any behavior except that it
fixes 3 warnings pasted to JIRA.
Those
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169691258
thrift_reserved_keyword(yytext); is used to report "Cannot use reserved
language keyword: " (reserved in Thrift target languages, not Thrift itself).
As "union" is
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169698270
Comment is from older version, which for some reason passed all unexpected
tokens to bison.. strange :)
So with comment removal this patch has my +1 :+1:
---
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/778
THRIFT-3528 Fix warnings in thrift.ll
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3528
Alternatively you can review and
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169499891
Could you explain what is going on here and why these entries have to be
changed/removed? I just don't get it, sorry.
---
If your project is set up for it, you can
