Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172646482
I am fairly sure that #797 fixes the line breaks and semi-colons in the
proper way. So, just check it with your code to make sure.
As far as performance of ARC I w
Github user ChristopherRogers commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172575020
Also, I just remembered from an old version of Xcode that even the @[]/@{}
syntax used autorelease (probably to easily codegen in both ARC and MRC) but
that mi
Github user ChristopherRogers commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172571012
Ah, my apologies for the extra semicolons. It was missing semicolons in the
default init methods where a collection type had a default value.
I believe
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172365685
@ChristopherRogers Please check #797 and see if it produces working code
for you as well.
---
If your project is set up for it, you can reply to this email and have your
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172362021
These do work with nested types so my hunch was wrong on that but with the
current code (including your PR) it now has awkward extra semi-colons; so my
munch was somewhat
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172357126
@ChristopherRogers Can you provide an example of what does not compile for
you?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172355763
Have these changes been tested with nested containers? I don't think they
will work.
My apologies for being late to the party. I am only scanning my thrift
emai
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/790
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user ChristopherRogers opened a pull request:
https://github.com/apache/thrift/pull/790
THRIFT-3545 Cocoa: Container type literals do not compile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChristopherRogers/thrift THR
