[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/826 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-03 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/826#issuecomment-179283037 OK, "read" was not a precise word. The problem I was trying to describe is about receiving boolean return value (not field) that happened to be `false`. At a quick

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-02 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/826#issuecomment-178662632 While it might fix a problem in sending `false` from Lua, combined send + receive test does not seem to work even with this fix. Do you want to fix reading side too

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-02 Thread mygityf
Github user mygityf commented on the pull request: https://github.com/apache/thrift/pull/826#issuecomment-178964162 To read a field by field id instead of argument of 'self ' in reading side. The problem can not be reproduced in reading side. --- If your project is set up for it,

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-01-31 Thread mygityf
GitHub user mygityf opened a pull request: https://github.com/apache/thrift/pull/826 THRIFT-3584 Lua: To check element of self whether nil or not,avoid the value(false) of BOOL is lost. …e value(false) of BOOL is lost. eg. Before: if self.argBool then