Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/870
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184704422
@nsuke just do it to make it better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184687016
@mygityf the failure is unrelated to your patch so no need to worry about
that any more.
Would you mind if I remove the comment as per @hcorg 's suggestion, now
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184556899
@nsuke I replace the PI and golden ratio with float literals and use the
same digits(17) in file lib/cpp/test/JSONProtoTest.cpp.
The result looks OK in Jenkins
Github user mygityf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/870#discussion_r52961339
--- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp ---
@@ -524,7 +524,8 @@ namespace {
std::string doubleToString(double d) {
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/870#discussion_r52925705
--- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp ---
@@ -524,7 +524,8 @@ namespace {
std::string doubleToString(double d) {
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184295292
Actually test is failing quite badly.
Your fix is fine but the test needs fix too.
A possible fix is to replace the PI and golden ratio with float literals
and use
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184066476
using 17 directly with a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184044511
thanks for uncovering it !
The "2" is for "0." ?
I think the comment can be improved.
@hcorg maybe you have better alternative than code comment here ?
---
If
