[GitHub] thrift pull request: THRIFT-3743 Java JSON protocol left in incorr...

2016-03-14 Thread stevenosborne-wf
Github user stevenosborne-wf commented on the pull request: https://github.com/apache/thrift/pull/947#issuecomment-196500957 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] thrift pull request: THRIFT-3743 Java JSON protocol left in incorr...

2016-03-14 Thread markerickson-wf
Github user markerickson-wf commented on the pull request: https://github.com/apache/thrift/pull/947#issuecomment-196488416 +1 We do something similar in Dart, for what it's worth - https://github.com/apache/thrift/blob/master/lib/dart/lib/src/protocol/t_json_protocol.dart#L18

[GitHub] thrift pull request: THRIFT-3743 Java JSON protocol left in incorr...

2016-03-14 Thread tylertreat-wf
Github user tylertreat-wf commented on the pull request: https://github.com/apache/thrift/pull/947#issuecomment-196485564 The Travis build failure appears to be an unrelated npm error... --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] thrift pull request: THRIFT-3743 Java JSON protocol left in incorr...

2016-03-14 Thread tylertreat-wf
GitHub user tylertreat-wf opened a pull request: https://github.com/apache/thrift/pull/947 THRIFT-3743 Java JSON protocol left in incorrect state when an exception is thrown during read or write operations This is the same issue as THRIFT-1473 (Delphi) and THRIFT-3735 (Go) but for