Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/961#discussion_r57957660
--- Diff: doc/specs/idl.md ---
@@ -126,8 +126,39 @@ A service provides the interface for a set of
functionality provided by a Thrift
### Field Requi
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/961#discussion_r57536860
--- Diff: doc/specs/idl.md ---
@@ -126,8 +126,39 @@ A service provides the interface for a set of
functionality provided by a Thrift
### Field Requ
Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/961#issuecomment-202165692
LGTM @Jens-G - just one question/comment above. Thanks for surfacing this
very important part of the spec in the docs!
---
If your project is set up for it, you can re
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/961#discussion_r57536162
--- Diff: doc/specs/idl.md ---
@@ -126,8 +126,39 @@ A service provides the interface for a set of
functionality provided by a Thrift
### Field Requ
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/961
THRIFT-3756 Improve requiredness documentation
Client: Website
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift
