Github user vmarkovtsev commented on the pull request:
https://github.com/apache/thrift/pull/972#issuecomment-207381112
Added the tutorial and some tests, fixed the comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/972#discussion_r58987066
--- Diff: test/py/TestAsyncioClient.py ---
@@ -0,0 +1,350 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Softwar
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/972#discussion_r58986861
--- Diff: test/tests.json ---
@@ -268,6 +268,41 @@
"workdir": "py"
},
{
+"comment": "Using 'python3' executable with asyncio",
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/972#issuecomment-207258086
@vmarkovtsev great, thanks for the tests and flake8 fix.
Could you also provide an example in either tutorial/py or
tutorial/py.asyncio directory ?
---
If your projec
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/972#discussion_r58986680
--- Diff: test/tests.json ---
@@ -268,6 +268,41 @@
"workdir": "py"
},
{
+"comment": "Using 'python3' executable with asyncio",
Github user vmarkovtsev commented on the pull request:
https://github.com/apache/thrift/pull/972#issuecomment-205262823
I've added the tests. These only belong to Client, since I do not plan to
port Server.
```
test/test.py --server cpp --client py3.asyncio
Apache Thri
Github user vmarkovtsev commented on the pull request:
https://github.com/apache/thrift/pull/972#issuecomment-205184422
@nsuke, about the generic wrapper, I feel bad about these dupes too but
cannot see the possibility because asyncio coroutine's "viral" nature with
"yield from" is go
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/972#issuecomment-204913981
@vmarkovtsev thanks for the contribution !
A few points:
* Is there any way to create a generic protocol wrapper ?
* gen_asyncio_ seems uninitialized.
* we n
Github user vmarkovtsev commented on the pull request:
https://github.com/apache/thrift/pull/972#issuecomment-204311613
``flake8 --ignore=E501 lib/py`` in Travis failed because the syntax "yield
from" is Python 3.3+ and flake [does not support
it](https://gitlab.com/pycqa/flake8/issue
GitHub user vmarkovtsev opened a pull request:
https://github.com/apache/thrift/pull/972
THRIFT-3770 Implement Python 3.4+ asyncio support
I decided to take an approach which is different from Tornado
implementation and do not nail supported protocols to the Framed one. My effort
e
10 matches
Mail list logo
