Github user Gjergj commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207782458
I finally succeeded to build for Android under Windows and Linux.
I took me one day and a half though.
Using Qt it would be much easier if one used Qt as client.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207398558
The toolchain file is rudimentary and full of hard coded values.
You can manually edit the file to match your environemnt or instead pick
more full fledged one from
Github user Gjergj commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207394496
I tried to build for Android under Linux but failed.
cmake -DCMAKE_TOOLCHAIN_FILE=../build/cmake/android-toolchain.cmake ..
Failed on serveral errors.
Do you
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207311366
FWIW I use Thrift C++ lib on Windows and Android.
We're building it for android only on Linux but I'm sure it's possible on
Windows too.
I guess it's a general
Github user Gjergj commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207300398
Since I use Qt for Android development an I use Windows as environment I
had a difficult time compiling TSocket for Android on Windows. And i figured
that QTcpSocket
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207295670
> I was just looking for something like TSocket based on Qt
Why you needed one ?
In other words, how does it work better for you compared to plain TSocket ?
Github user Gjergj commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207283113
@nsuke I was just looking for something like TSocket based on Qt as I
needed a synchronous client. And I do not see how async Qt sockets would fit in
synchronous client.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-207267343
@Gjergj to me, as Qt sockets are inherently async, synchronous-only support
seems a bit strange.
I think the whole point of existing TQTcpServer is to provide async
Github user Gjergj commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-206763268
lib/cpp/src/thrift/qt/TQIODeviceTransport.cpp seems to be written for
lib/cpp/src/thrift/qt/TQTcpServer.cpp which is an async server. The
Github user Gjergj commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-206486758
I'll have a look at TQIODeviceTransport and see how it works as a client.
As per config.h the idea is the same as in Windows port I guess.
My cmake exprience is
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/979#issuecomment-206477110
Why not enhance lib/cpp/src/thrift/qt/TQIODeviceTransport.cpp instead ?
As to the qmake file, I don't think we want to introduce yet another build
system.
As
Github user Gjergj commented on a diff in the pull request:
https://github.com/apache/thrift/pull/979#discussion_r58687272
--- Diff: lib/cpp/libthriftQt.pro ---
@@ -0,0 +1,161 @@
+QT += core network
+
+CONFIG += c++11
+
+greaterThan(QT_MAJOR_VERSION, 4):
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/979#discussion_r58678766
--- Diff: lib/cpp/libthriftQt.pro ---
@@ -0,0 +1,161 @@
+QT += core network
+
+CONFIG += c++11
+
GitHub user Gjergj opened a pull request:
https://github.com/apache/thrift/pull/979
THRIFT-3779 Qt Client Android and Windows QTcpSocket
libthriftQt.pro creates .dll and .lib for Windows but also .so and .a
libraries for Android.
To generate .lib or .a library uncomment CONFIG
14 matches
Mail list logo
