[GitHub] thrift pull request: THRIFT-3780 Use fixnum Int64 to write/read bi...

2016-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/983 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3780 Use fixnum Int64 to write/read bi...

2016-04-07 Thread markerickson-wf
Github user markerickson-wf commented on the pull request: https://github.com/apache/thrift/pull/983#issuecomment-207125660 +1 - the CI failures are in unrelated language - pairs so I don't have concerns about those. --- If your project is set up for it, you can reply to this email a

[GitHub] thrift pull request: THRIFT-3780 Use fixnum Int64 to write/read bi...

2016-04-07 Thread stevenosborne-wf
GitHub user stevenosborne-wf opened a pull request: https://github.com/apache/thrift/pull/983 THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64 Reading/writing `i64` is broken using the binary protocol when compiled to js. Use the [`fixnum`](https://pub.dartlang.org/pack