[GitHub] thrift pull request: THRIFT-809 JavaScript required fields

2014-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-809 JavaScript required fields

2014-10-06 Thread noazark
Github user noazark commented on the pull request: https://github.com/apache/thrift/pull/232#issuecomment-58058114 I'm not sure if I understand the problem. It looks like the failure occurs here (last line): ```js ThriftTest.Xception = function(args) {

[GitHub] thrift pull request: THRIFT-809 JavaScript required fields

2014-10-06 Thread noazark
Github user noazark commented on the pull request: https://github.com/apache/thrift/pull/232#issuecomment-58058863 Ahh, well the problem is not from my branch after all. See: https://travis-ci.org/apache/thrift/jobs/36996719#L4277 --- If your project is set up for it, you can reply

[GitHub] thrift pull request: THRIFT-809 JavaScript required fields

2014-10-06 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/232#issuecomment-58109612 hm... yes, you're right. Thanks for having a look. I don't have time to debug this now but it also need to be fixed. --- If your project is set up for it, you can

[GitHub] thrift pull request: THRIFT-809 JavaScript required fields

2014-10-03 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/232#issuecomment-5787 Please check https://travis-ci.org/apache/thrift/jobs/36811962#L4284 I think it's just a namespace problem. Cheers! --- If your project is set up for it, you

[GitHub] thrift pull request: THRIFT-809 JavaScript required fields

2014-10-01 Thread noazark
GitHub user noazark opened a pull request: https://github.com/apache/thrift/pull/232 THRIFT-809 JavaScript required fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/noazark/thrift thrift-809 Alternatively you can review