Github user cdwijayarathna closed the pull request at:
https://github.com/apache/thrift/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cdwijayarathna commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16324539
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16325863
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
Github user cdwijayarathna closed the pull request at:
https://github.com/apache/thrift/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user cdwijayarathna opened a pull request:
https://github.com/apache/thrift/pull/193
THRIFT-847 Test Framework harmonization across all languages
Edits suggested by @zilberstein added to Haskell tests.
You can merge this pull request into a Git repository by running:
$
Github user cdwijayarathna commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16325997
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52356290
@bufferoverflow Added changes suggested by @zilberstein in
https://github.com/cdwijayarathna/thrift/commit/33fe8f6da989181060d4c502a27426b7d57ff046
, should I
Github user zilberstein commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52356546
@cdwijayarathna, you can squash your commits and then force push to the
branch
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52357551
The changes within .travis.yml and contrib/installDependencies.sh are not
required.
you can do this:
{noformat}
diff --git a/lib/hs/Thrift.cabal
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52358462
@bufferoverflow Added suggested changes and committed. Is there anything
else I need to do for this?
---
If your project is set up for it, you can reply to this
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52358999
please fix all the white space issues
e.g contrib/installDependencies.sh and many other areas had no changes
---
If your project is set up for it, you can
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52359230
You also might start using --port=${THRIFT_TEST_PORT}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52359274
I removed trailing white spaces in files I edited, do I need to undo them?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16316474
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/190#issuecomment-52360323
sorry, I did not recognized that. Perfect!
committed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cdwijayarathna commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16316696
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16317049
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
Github user zilberstein commented on a diff in the pull request:
https://github.com/apache/thrift/pull/190#discussion_r16317067
--- Diff: test/hs/TestClient.hs ---
@@ -197,24 +198,24 @@ main = do
Binary - runClient $ BinaryProtocol handle
Compact
18 matches
Mail list logo
