Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66847789
looking great Pascal!
+1
ps.: so I guess JS would be pretty straightforward to convert too as it
also uses ant
---
If your project is set up for it, you can rep
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66850037
check https://issues.apache.org/jira/browse/THRIFT-2850
maybe those two changes can be merged
---
If your project is set up for it, you can reply to this email and
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66887590
@hcorg this is https://issues.apache.org/jira/browse/THRIFT-2850
Pascal Bach, Sergei Nikulov and I worked on this together.
I suggest to merge this and impr
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66889612
Great!
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67069087
I started similar work at [1] with a slightly different approach. I dont
think that we should reference any autoconf from within cmake or try and work
around it, but rat
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67094076
Great Jake, it looks like it shouldn't be hard to integrate your rb and py
cmakelists onto this.
I think theses guys are using very good common practices for cmake, f
Github user bachp commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67304692
Hi Jake
I had a look at your cmake branch. It looks good and the python and ruby
integrations are nice. I added some comments to your
[commit](https://github.com/j
Github user bachp commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67340902
@jfarrell Regarding the referencing of autoconf I think the only place we
do that is to get the version number. This was just done to avoid having to
change the number in y
Github user bachp closed the pull request at:
https://github.com/apache/thrift/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user bachp commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-143357590
I think theis is obsolete now. I will close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
10 matches
Mail list logo
