Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39995173
Thanks guys, fix: https://github.com/apache/thrift/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user snikulov commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39987106
@djwatson Yes. my _types.cpp is linked in.
But as @henrique mentioned _presult and _pargs destructor's are not
generated and thus linker gives error.
---
If your pro
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39985522
Hi Dave,
This destructor is only for structs, isn't it?
The ld error is for *_presult and *_pargs
---
If your project is set up for it, you can reply to this emai
Github user ben-craig commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39977940
There's a log of a failure in Thrift's nightly build.
https://builds.apache.org/job/Thrift/1123/console
tutorial/shared.thrift and tutorial/tutorial.thri
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39975322
The destructor is defined in the .cpp file now:
// Destructor
+ if (tstruct->annotations_.find("final") == tstruct->annotations_.end())
{
+out <<
Github user snikulov commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39949481
This change breaks c++ generation.
After this change in compiler/cpp/src/generate/t_cpp_generator.cc
- indent() << "virtual ~" << tstruct->get_name()
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-38307172
Thanks @djwatson created THRIFT-2421 to track it and will review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/84
Tree/Recursive struct support in thrift
Patches to implement tree/list/co-recursive structures in thrift, a la
protobufs.
You can merge this pull request into a Git repository by running:
$ gi
