Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/396#issuecomment-93615711
Thanks for your patch @forrestc, in order for us to accept a pull request
we need to have a jira ticket associated with it. Please see our contributing
guide at http://t
Github user RandyAbernethy commented on the pull request:
https://github.com/apache/thrift/pull/396#issuecomment-78527156
Hello Forrest,
The Thrift project accepts pull requests but they have to be attached to a
Jira Issue. If you create a Jira Issue for this here:
https:
GitHub user forrestc opened a pull request:
https://github.com/apache/thrift/pull/396
Update thrift.js
Error.message and stack are non-enumerable properties, which cannot be
inherited by util.inherits. It is annoying that an Exception object doesn't
contain a message, so it is a cr