Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52769020
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(un
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52768604
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(unit
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52766891
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(un
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52766421
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -42,22 +43,50 @@
CLIENT_KEY = os.path.join(ROOT_DIR, 'test', 'keys', 'client_v3.key')
CLIENT_CA = os.p
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52766168
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -42,22 +43,50 @@
CLIENT_KEY = os.path.join(ROOT_DIR, 'test', 'keys', 'client_v3.key')
CLIENT_CA = os.pat
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52765986
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(unit
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52765381
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(un
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52765229
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(un
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52765133
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -42,22 +43,50 @@
CLIENT_KEY = os.path.join(ROOT_DIR, 'test', 'keys', 'client_v3.key')
CLIENT_CA = os.p
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52765017
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -42,22 +43,50 @@
CLIENT_KEY = os.path.join(ROOT_DIR, 'test', 'keys', 'client_v3.key')
CLIENT_CA = os.p
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52764813
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -42,22 +43,50 @@
CLIENT_KEY = os.path.join(ROOT_DIR, 'test', 'keys', 'client_v3.key')
CLIENT_CA = os.pat
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52764799
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -42,22 +43,50 @@
CLIENT_KEY = os.path.join(ROOT_DIR, 'test', 'keys', 'client_v3.key')
CLIENT_CA = os.pat
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52764647
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(unit
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/850#discussion_r52764385
--- Diff: lib/py/test/test_sslsocket.py ---
@@ -75,185 +104,176 @@ def __exit__(self, exc_type, exc_value, traceback):
class TSSLSocketTest(unit
Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/850#issuecomment-183379947
Noting that Jenkins CI failed on lib/cpp/test/SecurityTest.cpp before
getting to test_sslsocket.py.
I have a fix for the SecurityTest in #848 that still needs review
Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/850#issuecomment-183369497
@nsuke - hoping you have time to review this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/850
lib/py/test/test_sslsocket.py is flaky
Previously a combination of fixed ports, fixed paths and delays was used
in all TSSLSocketTest tests that involved making a client-server
connection; no
18 matches
Mail list logo
