[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-10-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-29 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r81125635 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-29 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r81119054 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r81062337 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r81000970 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80994513 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80977866 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80976940 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80976274 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80975121 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1099 THRIFT-3936: fix compile error on VS2013 and earlier Submitting to replace https://github.com/apache/thrift/pull/1096. You can merge this pull request into a Git repository by running: $ git p