Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1120#discussion_r90043799
--- Diff: test/JavaTypes.thrift ---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1120#discussion_r90040746
--- Diff: test/JavaTypes.thrift ---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1120#discussion_r90040582
--- Diff: lib/java/test/org/apache/thrift/test/TestClient.java ---
@@ -576,7 +581,7 @@ public static void main(String [] args) {
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1120#discussion_r87700206
--- Diff: test/JavaTypes.thrift ---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
GitHub user bgould opened a pull request:
https://github.com/apache/thrift/pull/1120
THRIFT-3301: Naming collisions possible in generated Java code
Switched to fully-qualified names for all class name references in
generated code. Added test IDL to verify generated code compiles
