Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1129#discussion_r87711314
--- Diff: lib/cpp/src/thrift/concurrency/Mutex.cpp ---
@@ -37,11 +37,10 @@ namespace concurrency {
#ifndef THRIFT_NO_CONTENTION_PROFILING
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1129#discussion_r87709373
--- Diff: lib/cpp/src/thrift/concurrency/Mutex.h ---
@@ -101,25 +101,6 @@ class ReadWriteMutex {
boost::shared_ptr impl_;
};
-/**
- *
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1129#discussion_r87707817
--- Diff: lib/cpp/src/thrift/concurrency/Mutex.cpp ---
@@ -37,11 +37,10 @@ namespace concurrency {
#ifndef THRIFT_NO_CONTENTION_PROFILING
+
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1129
THRIFT-3038 clean up remaining volatile issues; remove unused
NoStarveReadWriteMutex class
This takes care of items 1, 3, and 6 in the PR description.
You can merge this pull request into a Git re
