[GitHub] thrift pull request #1141: support for timeout in node http connection

2017-10-25 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r146879631 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93458710 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93457348 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.http

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93437696 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93419768 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.http

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93412832 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93392404 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.http

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93389394 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93375825 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.http

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93366270 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-18 Thread guptanishank
GitHub user guptanishank opened a pull request: https://github.com/apache/thrift/pull/1141 support for timeout in node http connection You can merge this pull request into a Git repository by running: $ git pull https://github.com/guptanishank/thrift master Alternatively you