Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211560
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211272
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211074
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210978
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210903
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210872
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126537
--- Diff: .gitignore ---
@@ -206,6 +206,7 @@ project.lock.json
/lib/delphi/test/typeregistry/*.local
/lib/delphi/test/typeregistry/*.dcu
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126534
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -2722,7 +2756,30 @@ string t_rs_generator::rust_namespace(t_service*
tservice) {
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126542
--- Diff: .gitignore ---
@@ -281,6 +293,7 @@ project.lock.json
/test/log/
/test/test.log
/test/erl/.generated
+/test/erl/.rebar
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126529
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
--- End diff --
@anatol I've previously changed this -
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96123137
--- Diff: .gitignore ---
@@ -206,6 +206,7 @@ project.lock.json
/lib/delphi/test/typeregistry/*.local
/lib/delphi/test/typeregistry/*.dcu
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96123141
--- Diff: .gitignore ---
@@ -281,6 +293,7 @@ project.lock.json
/test/log/
/test/test.log
/test/erl/.generated
+/test/erl/.rebar
--- End
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94457731
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -2722,7 +2756,30 @@ string t_rs_generator::rust_namespace(t_service*
tservice) {
}
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94576295
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -0,0 +1,2846 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94510188
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -0,0 +1,2846 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94371350
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94370827
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
+description = "Rust Thrift library"
+version = "0.5.1"
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94356759
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
+description = "Rust Thrift library"
+version = "0.5.1"
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94354976
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
+description = "Rust Thrift library"
+version = "0.5.1"
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94354857
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2:
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94347222
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
+description = "Rust Thrift library"
+version = "0.5.1"
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94346784
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94346650
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94333540
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94331438
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
+description = "Rust Thrift library"
+version = "0.5.1"
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94331337
--- Diff: test/csharp/TestServer.cs ---
@@ -273,39 +273,24 @@ public long testTypedef(long thing)
return mapmap;
}
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94303703
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
+description = "Rust Thrift library"
+version = "0.5.1"
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94302235
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94297395
--- Diff: test/csharp/TestServer.cs ---
@@ -273,39 +273,24 @@ public long testTypedef(long thing)
return mapmap;
}
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94287266
--- Diff: test/csharp/TestServer.cs ---
@@ -273,39 +273,24 @@ public long testTypedef(long thing)
return mapmap;
}
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94287260
--- Diff: test/ThriftTest.thrift ---
@@ -115,14 +115,6 @@ struct CrazyNesting {
4: binary binary_field
}
-union SomeUnion {
---
GitHub user allengeorge opened a pull request:
https://github.com/apache/thrift/pull/1147
THRIFT-2945 Add Rust support
This is a PR to add Rust support to Thrift. It is based on today's master,
and I've verified that Rust server/client successfully communicates with all
32 matches
Mail list logo
