Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r97247885
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876704
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -101,9 +102,6 @@ THRIFT_ADD_COMPILER(xml "Enable compiler for XML"
ON)
# we also add the current
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876857
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -16,30 +16,30 @@
# specific language governing permissions and limitations
# under the License.
#
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876685
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1161
Thrift-4034 CMake doesn't work to build compiler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift THRIFT-4034