[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132017398 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132013921 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132013793 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132013676 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread octopus-prime
Github user octopus-prime commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131985807 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread octopus-prime
Github user octopus-prime commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131985042 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131968863 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131968203 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared p

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131966861 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared p

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-05 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1328 THRIFT-2221: detect C++11 and use std namespace for memory operations (smart_ptr) I had to close my older pull request because the history got tainted, so I am reopening it with the suggestions fr