Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1353
---
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138849538
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -69,28 +72,33 @@ class TimerManager {
*
* @param task The task to execute
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138849560
--- Diff: lib/cpp/test/concurrency/TimerManagerTests.h ---
@@ -192,6 +192,38 @@ class TimerManagerTests {
return true;
}
+/**
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138845074
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -100,13 +108,26 @@ class TimerManager {
*/
virtual void remove(stdcxx::shared_ptr
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138711396
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -100,13 +108,26 @@ class TimerManager {
*/
virtual void remove(stdcxx::shared_p
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138711309
--- Diff: lib/cpp/test/concurrency/TimerManagerTests.h ---
@@ -192,6 +192,38 @@ class TimerManagerTests {
return true;
}
+/**
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138711130
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -69,28 +72,33 @@ class TimerManager {
*
* @param task The task to execute
GitHub user Typz opened a pull request:
https://github.com/apache/thrift/pull/1353
THRIFT-4327: add API to efficiently remove a single timer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Typz/thrift THRIFT-4327
Alternatively y
