Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375270
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
As usually - some settings of different editors. Maybe you can provide
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375244
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375224
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375213
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375191
--- Diff: test/features/known_failures_Linux.json ---
@@ -1,46 +1,48 @@
[
- "c_glib-limit_container_length_binary_buffered-ip",
--- End diff --
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161374818
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
Here's the diff
```
diff tests.json.old.normalized
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373936
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
By changing the indentation you have made it a very difficult task to
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373681
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373426
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373415
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161372982
--- Diff: test/features/known_failures_Linux.json ---
@@ -1,46 +1,48 @@
[
- "c_glib-limit_container_length_binary_buffered-ip",
--- End diff
GitHub user vgotra opened a pull request:
https://github.com/apache/thrift/pull/1449
THRIFT-4434. Update .NET Core components, add tests for .Net Core library
and .Net Core compiler, fix bugs and build process
This pull request should:
- highly improve the current version
12 matches
Mail list logo
