[ https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264950#comment-14264950 ]
Radoslaw Gruchalski edited comment on THRIFT-2926 at 1/5/15 7:26 PM: --------------------------------------------------------------------- I’d love to, it would be awesome to provide this to the community but the PhantomJS issue will prevent unicode characters decryption. The only way I can make this test to pass is to remove unicode characters from the test :( It work perfectly in the browser. I’m running this code here: https://github.com/radekg/gossiperl-client-chrome. Kind regards, Radek Gruchalski de.linkedin.com/in/radgruchalski/ (http://de.linkedin.com/in/radgruchalski/) Confidentiality: This communication is intended for the above-named person and may be confidential and/or legally privileged. If it has come to you in error you must take no action based on it, nor must you copy or show it to anyone; please delete/destroy and inform the sender immediately. was (Author: radekg): I’d love to, it would be awesome to provide this to the community but the PhantomJS issue will prevent unicode characters decryption. The only way I can make this test to pass is to remove unicode characters from the test :( It work perfectly in the browser. I’m running this code here: https://github.com/radekg/gossiperl-client-chrome. Kind regards, Radek Gruchalski ra...@gruchalski.com (mailto:ra...@gruchalski.com) (mailto:ra...@gruchalski.com) de.linkedin.com/in/radgruchalski/ (http://de.linkedin.com/in/radgruchalski/) +4917685656526 Confidentiality: This communication is intended for the above-named person and may be confidential and/or legally privileged. If it has come to you in error you must take no action based on it, nor must you copy or show it to anyone; please delete/destroy and inform the sender immediately. > JavaScript: binary protocol implementation > ------------------------------------------ > > Key: THRIFT-2926 > URL: https://issues.apache.org/jira/browse/THRIFT-2926 > Project: Thrift > Issue Type: Sub-task > Components: JavaScript - Library > Affects Versions: 0.9.2 > Reporter: Radoslaw Gruchalski > Assignee: Randy Abernethy > Labels: features, javascript > > I have implemented BinaryProtocol for the JS library. Implementation provided > with unit tests. Looking for feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)