[
https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610949#comment-14610949
]
Jens Geyer edited comment on THRIFT-3214 at 7/1/15 8:24 PM:
------------------------------------------------------------
Thanks for the patch, a few comments:
1. Could ypou move the test into {{/lib/erl/test}} etc rather than
{{/test/erl}}? I know this is a bit counterintuitive, but the global {{/test}}
folder is intended for the Thrift (cross) test. Language specific tests should
be placed in their {{lib/language/test}} folder.
2. At least one file is missing the ASF license header.
was (Author: jensg):
Could ypou move the test into {{/lib/erl/test}} etc rather than {{/test/erl}}?
I know this is a bit counterintuitive, but the global {{/test}} folder is
intended for the Thrift (cross) test. Language specific tests should be placed
in their {{lib/language/test}} folder.
> Add Erlang option for using maps instead of dicts
> -------------------------------------------------
>
> Key: THRIFT-3214
> URL: https://issues.apache.org/jira/browse/THRIFT-3214
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Compiler
> Reporter: Michael Oliver
> Assignee: Michael Oliver
> Priority: Minor
>
> Erlang OTP 18 introduces significant performance improvements when using maps
> instead of dicts. Here is a benchmark showing the gains:
> https://gist.github.com/BinaryMuse/bb9f2cbf692e6cfa4841
> Thrift should support an option for the Erlang compiler to produce maps
> instead of dicts, to take advantage of these performance improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
