[ 
https://issues.apache.org/jira/browse/THRIFT-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099797#comment-16099797
 ] 

Roy Sindre Norangshol edited comment on THRIFT-4126 at 7/25/17 10:09 AM:
-------------------------------------------------------------------------

[~jking]:

This patch is causing issues for us in production when we tried to use latest 
master with php 7.1.7.
Running this in our test suite under valgrind shows corrupted memory and 
segfaults.  

EDIT: Backtracing debugging from yesterday, I have to admit we used a compiler 
from 20170627 and not latest master which might have caused issues. 


was (Author: rockj):
[~jking]:

This patch is causing issues for us in production when we tried to use latest 
master with php 7.1.7.
Running this in our test suite under valgrind shows corrupted memory and 
segfaults.  

> Validate objects in php extension
> ---------------------------------
>
>                 Key: THRIFT-4126
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4126
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler, PHP - Library
>            Reporter: Myroslav Kosinskyi
>            Assignee: Myroslav Kosinskyi
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> Now there is  not validation if required fields are set when we use php 
> extension to serialize and deserialize thrift objects.
> So i have implemented this feature
> And i am going to create a pull request soon



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to