[ https://issues.apache.org/jira/browse/THRIFT-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253476#comment-13253476 ]
Hudson commented on THRIFT-1570: -------------------------------- Integrated in Thrift #438 (See [https://builds.apache.org/job/Thrift/438/]) THRIFT-1570 Correctly generate code for empty services. Patch: Dave Watson (Revision 1325786) Result = SUCCESS roger : http://svn.apache.org/viewvc/?view=rev&rev=1325786 Files : * /thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc > Correctly generate code for empty services. > -------------------------------------------- > > Key: THRIFT-1570 > URL: https://issues.apache.org/jira/browse/THRIFT-1570 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Reporter: Dave Watson > Assignee: Dave Watson > Priority: Minor > Attachments: 0012-Correctly-generate-code-for-empty-services.patch > > > From 2f363522262eca7cb99c3567fa77c92c3243265f Mon Sep 17 00:00:00 2001 > From: Peter Griess <pgri...@fb.com> > Date: Thu, 16 Dec 2010 21:55:32 +0000 > Subject: [PATCH 12/12] Correctly generate code for empty services. > Summary: > - Don't emit the 'else' clause for the method switch in the generated > client if the service doesn't have any methods. > Test Plan: > - Tested generating Python code for an empty service before and after. > DiffCamp Revision: 193807 > Reviewers: rajesh, simpkins > CC: mpage, doug, dreiss, rajesh, thrift-team@lists > Tasks: > #457923: Thrift generates broken Python code for empty services > Revert Plan: > OK > git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@46847 > 2248de34-8caa-4a3c-bc55-5e52d9d7b73a > --- > compiler/cpp/src/generate/t_py_generator.cc | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira