[
https://issues.apache.org/jira/browse/THRIFT-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735818#comment-16735818
]
James E. King III commented on THRIFT-1947:
---
Given THRIFT-4720 has moved us to
[
https://issues.apache.org/jira/browse/THRIFT-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692858#comment-13692858
]
Vitali Lovich commented on THRIFT-1947:
---
Oh. One more point. If there is only 1 ar
[
https://issues.apache.org/jira/browse/THRIFT-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689373#comment-13689373
]
Vitali Lovich commented on THRIFT-1947:
---
* You were using string concatenation to b
[
https://issues.apache.org/jira/browse/THRIFT-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688154#comment-13688154
]
Vitali Lovich commented on THRIFT-1947:
---
Looks good overall. Notes:
- Instead of
[
https://issues.apache.org/jira/browse/THRIFT-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643798#comment-13643798
]
Roger Meier commented on THRIFT-1947:
-
+1
> C++ constructor with ini