[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-11-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197501#comment-14197501 ] Hudson commented on THRIFT-2632: SUCCESS: Integrated in Thrift #1331 (See [https://build

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073773#comment-14073773 ] Hudson commented on THRIFT-2632: FAILURE: Integrated in Thrift #1230 (See [https://build

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072272#comment-14072272 ] Jens Geyer commented on THRIFT-2632: Hi, thanks, adding a test is a good idea.! May

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-23 Thread Stig Bakken (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071518#comment-14071518 ] Stig Bakken commented on THRIFT-2632: - Gotcha! Fixed, and added a test script for go

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070919#comment-14070919 ] Jens Geyer commented on THRIFT-2632: {quote} validateForRead() will be called in the

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-22 Thread Stig Bakken (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069936#comment-14069936 ] Stig Bakken commented on THRIFT-2632: - Hi Jens, Thanks for the feedback! 1. validat

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069431#comment-14069431 ] Jens Geyer commented on THRIFT-2632: Hi, two remarks: * In the generated code, {{va

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069292#comment-14069292 ] ASF GitHub Bot commented on THRIFT-2632: Github user Jens-G commented on the pull