[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569152#comment-15569152 ] ASF GitHub Bot commented on THRIFT-3546: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-12 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568897#comment-15568897 ] Randy Abernethy commented on THRIFT-3546: - +1 > NodeJS code should not be namesp

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565717#comment-15565717 ] ASF GitHub Bot commented on THRIFT-3546: Github user jfarrell commented on the is

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565392#comment-15565392 ] Benjamin Gould commented on THRIFT-3546: Added to my PR to emit a "use strict" di

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-06 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552929#comment-15552929 ] Benjamin Gould commented on THRIFT-3546: The above PR also fixes THRIFT-3835 if I

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552922#comment-15552922 ] ASF GitHub Bot commented on THRIFT-3546: GitHub user bgould opened a pull request

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-06 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552898#comment-15552898 ] Benjamin Gould commented on THRIFT-3546: I have a fix for this that eliminates th