[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153061#comment-16153061
]
James E. King, III commented on THRIFT-3932:
Recommend you send your request
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153037#comment-16153037
]
Buğra Gedik commented on THRIFT-3932:
-
Sorry, I commented on the wrong Jira item. I m
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153036#comment-16153036
]
James E. King, III commented on THRIFT-3932:
This was fixed and released into
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152958#comment-16152958
]
Buğra Gedik commented on THRIFT-3932:
-
Hi [~jking3]. Do you know if there are any rel
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660226#comment-15660226
]
ASF GitHub Bot commented on THRIFT-3932:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655192#comment-15655192
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582594#comment-15582594
]
ASF GitHub Bot commented on THRIFT-3932:
Github user ben-craig commented on the i
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582535#comment-15582535
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582485#comment-15582485
]
ASF GitHub Bot commented on THRIFT-3932:
Github user ben-craig commented on the i
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582271#comment-15582271
]
James E. King, III commented on THRIFT-3932:
[~jfarrell] sounds good.
> C++
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582164#comment-15582164
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572126#comment-15572126
]
ASF GitHub Bot commented on THRIFT-3932:
Github user ben-craig commented on the i
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571808#comment-15571808
]
Jake Farrell commented on THRIFT-3932:
--
Ran through the patch and with the size and
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549639#comment-15549639
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542525#comment-15542525
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542125#comment-15542125
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542093#comment-15542093
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542090#comment-15542090
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542065#comment-15542065
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15541375#comment-15541375
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on the issue
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540909#comment-15540909
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540560#comment-15540560
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540555#comment-15540555
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on the issue
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540503#comment-15540503
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540466#comment-15540466
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540445#comment-15540445
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540426#comment-15540426
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540402#comment-15540402
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540389#comment-15540389
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540376#comment-15540376
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540365#comment-15540365
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540364#comment-15540364
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540326#comment-15540326
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540324#comment-15540324
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540322#comment-15540322
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540310#comment-15540310
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540309#comment-15540309
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540311#comment-15540311
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540312#comment-15540312
]
ASF GitHub Bot commented on THRIFT-3932:
Github user nsuke commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540302#comment-15540302
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540152#comment-15540152
]
Buğra Gedik commented on THRIFT-3932:
-
Could it be that the notification goes too ear
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15539293#comment-15539293
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15539162#comment-15539162
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15539134#comment-15539134
]
James E. King, III commented on THRIFT-3932:
I tried to re-enable some tests
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538952#comment-15538952
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538745#comment-15538745
]
James E. King, III commented on THRIFT-3932:
Done.
> C++ ThreadManager has a
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538724#comment-15538724
]
James E. King, III commented on THRIFT-3932:
Ah, the original logic in remove
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538551#comment-15538551
]
ASF GitHub Bot commented on THRIFT-3932:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538134#comment-15538134
]
Buğra Gedik commented on THRIFT-3932:
-
Looks good to me.
> C++ ThreadManager has a r
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537938#comment-15537938
]
James E. King, III commented on THRIFT-3932:
I found a number of issues that
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537932#comment-15537932
]
ASF GitHub Bot commented on THRIFT-3932:
GitHub user jeking3 opened a pull reques
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536702#comment-15536702
]
Buğra Gedik commented on THRIFT-3932:
-
Thanks [~jking]
> C++ ThreadManager has a rar
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536687#comment-15536687
]
James E. King, III commented on THRIFT-3932:
I've done a fair bit of work in
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534011#comment-15534011
]
James E. King, III commented on THRIFT-3932:
I agree; this is not providing t
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533833#comment-15533833
]
Buğra Gedik commented on THRIFT-3932:
-
You are right, that one addresses the same iss
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533786#comment-15533786
]
James E. King, III commented on THRIFT-3932:
Could you rework your patch on m
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523411#comment-15523411
]
Buğra Gedik commented on THRIFT-3932:
-
Btw, the change I made to the initialization o
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523383#comment-15523383
]
Buğra Gedik commented on THRIFT-3932:
-
Please go ahead.
> C++ ThreadManager has a ra
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523358#comment-15523358
]
James E. King, III commented on THRIFT-3932:
I am planning on reviewing this,
59 matches
Mail list logo