[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418942#comment-16418942 ] ASF GitHub Bot commented on THRIFT-4530: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418924#comment-16418924 ] ASF GitHub Bot commented on THRIFT-4530: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418176#comment-16418176 ] ASF GitHub Bot commented on THRIFT-4530: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418132#comment-16418132 ] ASF GitHub Bot commented on THRIFT-4530: Github user msridhar commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417654#comment-16417654 ] ASF GitHub Bot commented on THRIFT-4530: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417645#comment-16417645 ] ASF GitHub Bot commented on THRIFT-4530: Github user msridhar commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417221#comment-16417221 ] ASF GitHub Bot commented on THRIFT-4530: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416594#comment-16416594 ] ASF GitHub Bot commented on THRIFT-4530: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416581#comment-16416581 ] ASF GitHub Bot commented on THRIFT-4530: Github user msridhar commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416443#comment-16416443 ] ASF GitHub Bot commented on THRIFT-4530: Github user msridhar commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416437#comment-16416437 ] ASF GitHub Bot commented on THRIFT-4530: GitHub user msridhar opened a pull request:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413981#comment-16413981 ] James E. King, III commented on THRIFT-4530: If nullable annotations have no other

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412550#comment-16412550 ] Can Celasun commented on THRIFT-4530: - I think it's better if they are on by default, but if anyone

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412392#comment-16412392 ] Manu Sridharan commented on THRIFT-4530: Great!  I will definitely post the PR on GitHub. Do we

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412173#comment-16412173 ] Can Celasun commented on THRIFT-4530: - I think it's a good idea. Regarding which annotation to use, I