[jira] [Commented] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744558#comment-16744558 ] James E. King III commented on THRIFT-4741: --- The pull request is fine, I'm just saying the

[jira] [Commented] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744557#comment-16744557 ] Jens Geyer commented on THRIFT-4741: I shortly considered putting both changes into one PR, but did

[jira] [Commented] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744550#comment-16744550 ] James E. King III commented on THRIFT-4741: --- I'd suggest for items like this which are fairly