[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2021-01-22 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270055#comment-17270055 ] Duru Can Celasun commented on THRIFT-4914: -- Sounds reasonable. I agree that there are likely

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2021-01-21 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269948#comment-17269948 ] Yuxuan Wang commented on THRIFT-4914: - [~dcelasun] After wrote

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-11-09 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970966#comment-16970966 ] Duru Can Celasun commented on THRIFT-4914: -- With the last PR merged, I believe we're done with

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-11-09 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970962#comment-16970962 ] Duru Can Celasun commented on THRIFT-4914: -- It's small enough, so why not :) > Go: Link

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-11-09 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970960#comment-16970960 ] Yuxuan Wang commented on THRIFT-4914: - I created https://github.com/apache/thrift/pull/1926 anyway,

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-11-09 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970954#comment-16970954 ] Duru Can Celasun commented on THRIFT-4914: -- bq. In our use case the client almost always have

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-11-09 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970950#comment-16970950 ] Yuxuan Wang commented on THRIFT-4914: - Now we only have clients reading from responses left. In our

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955213#comment-16955213 ] Duru Can Celasun commented on THRIFT-4914: -- OK, sounds good! When you have some code, please

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-19 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955204#comment-16955204 ] Yuxuan Wang commented on THRIFT-4914: - What I was thinking is something like this: {code:go} type

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955096#comment-16955096 ] Duru Can Celasun commented on THRIFT-4914: -- I'm strongly against exposing the transport in

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955062#comment-16955062 ] Yuxuan Wang commented on THRIFT-4914: - [~dcelasun] Actually I just had a different idea. I think

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954914#comment-16954914 ] Duru Can Celasun commented on THRIFT-4914: -- > It's breaking in the way that the business logic

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954903#comment-16954903 ] Yuxuan Wang commented on THRIFT-4914: - It's breaking in the way that the business logic code around

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954883#comment-16954883 ] Yuxuan Wang commented on THRIFT-4914: - But another problem is that if we choose map now, and later

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954880#comment-16954880 ] Duru Can Celasun commented on THRIFT-4914: -- That's a very good point, a simple

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954825#comment-16954825 ] Yuxuan Wang commented on THRIFT-4914: - I think returning a struct is on the right direction, but I'm

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-18 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954410#comment-16954410 ] Duru Can Celasun commented on THRIFT-4914: -- > if we want something similar that's injected in

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2019-10-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954133#comment-16954133 ] Duru Can Celasun commented on THRIFT-4914: -- [~fishywang], now that the first part is released